Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dop): some bug metrics should not contain wont fix states #6066

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

chengjoey
Copy link
Contributor

What this PR does / why we need it:

fix some bug metrics should not contain wont fix states

Specified Reviewers:

/assign @sfwn

ChangeLog

Language Changelog
🇺🇸 English fix some bug metrics should not contain wont fix states
🇨🇳 中文 修复效能度量缺陷指标包含了无需修复状态的问题

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot added bugfix dop devops plaoform labels Sep 26, 2023
@erda-bot erda-bot requested a review from sfwn September 26, 2023 09:47
@@ -59,13 +59,13 @@ func (p *provider) calPersonalFields(personalInfo *PersonalPerformanceInfo) (*pe
if err != nil {
return nil, err
}
demandBugTotal, err := p.issueDB.GetBugCountByUserID(userID, projectID, wontfixStateIDS, []string{"demandDesign"}, nil, false, 0)
demandBugTotal, err := p.issueDB.GetBugCountByUserID(userID, projectID, wontfixStateIDS, []string{"demandDesign", "需求设计", "架构设计", "architectureDesign", "需求调研"}, nil, false, 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get by env

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@chengjoey chengjoey force-pushed the fix/efficiency-bug-total branch from 0e0bd7e to 362ac56 Compare September 26, 2023 10:08
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #6066 (362ac56) into master (04fe227) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6066      +/-   ##
==========================================
- Coverage   22.80%   22.79%   -0.01%     
==========================================
  Files        1768     1768              
  Lines      190806   190806              
==========================================
- Hits        43512    43503       -9     
- Misses     142306   142311       +5     
- Partials     4988     4992       +4     

see 7 files with indirect coverage changes

@sfwn
Copy link
Member

sfwn commented Sep 26, 2023

/approve

@erda-bot erda-bot merged commit b59667a into erda-project:master Sep 26, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants