Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong inject registercenter version key #6471

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

CeerDecy
Copy link
Member

What this PR does / why we need it:

fix wrong inject registercenter version key, change Version to version

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx @sfwn

ChangeLog

Language Changelog
🇺🇸 English fix wrong inject registercenter version key, change Version to version
🇨🇳 中文 修复了为没有设置版本的注册中心注入版本时设置了错误的Key

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested review from iutx and sfwn November 28, 2024 01:38
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfwn
Copy link
Member

sfwn commented Nov 28, 2024

/approve

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.11%. Comparing base (9aaa584) to head (af1ece8).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6471      +/-   ##
==========================================
- Coverage   15.14%   15.11%   -0.04%     
==========================================
  Files        3674     3675       +1     
  Lines      376844   376996     +152     
==========================================
- Hits        57076    56985      -91     
- Misses     314307   314564     +257     
+ Partials     5461     5447      -14     
Flag Coverage Δ
by-github-actions 15.11% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nternal/tools/orchestrator/services/addon/addon.go 13.56% <ø> (-0.09%) ⬇️

... and 21 files with indirect coverage changes

@erda-bot erda-bot merged commit 0a48220 into erda-project:master Nov 28, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants