Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: runtime run as no-root user #6474

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

CeerDecy
Copy link
Member

@CeerDecy CeerDecy commented Dec 6, 2024

What this PR does / why we need it:

runtime run as no-root user

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx

ChangeLog

Language Changelog
🇺🇸 English runtime run as no-root user
🇨🇳 中文 runtime以非root用户运行

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot
Copy link
Member

erda-bot commented Dec 6, 2024

Add assignees failed, err: Post "https://api.github.com/repos/erda-project/erda/pulls/6474/requested_reviewers": proxyconnect tcp: dial tcp 8.218.184.45:34894: i/o timeout

@CeerDecy CeerDecy requested review from iutx and sfwn and removed request for iutx December 6, 2024 07:40
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 34.02062% with 64 lines in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (9aaa584) to head (24f352b).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...tools/orchestrator/scheduler/executor/util/util.go 46.47% 30 Missing and 8 partials ⚠️
...orchestrator/scheduler/executor/plugins/k8s/k8s.go 0.00% 26 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6474      +/-   ##
==========================================
- Coverage   15.14%   15.12%   -0.02%     
==========================================
  Files        3674     3675       +1     
  Lines      376844   377102     +258     
==========================================
- Hits        57076    57048      -28     
- Misses     314307   314593     +286     
  Partials     5461     5461              
Flag Coverage Δ
by-github-actions 15.12% <34.02%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...duler/executor/plugins/k8s/instanceinfosync/pod.go 0.00% <ø> (ø)
...orchestrator/scheduler/executor/plugins/k8s/k8s.go 25.16% <0.00%> (-0.44%) ⬇️
...tools/orchestrator/scheduler/executor/util/util.go 39.16% <46.47%> (+1.95%) ⬆️

... and 23 files with indirect coverage changes

@CeerDecy CeerDecy marked this pull request as draft December 9, 2024 02:00
@CeerDecy CeerDecy marked this pull request as ready for review December 9, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants