Change import to support Django 4.0 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Django 4.0 remove the ugettext_ family of functions](https://docs.djangoproject.com/en/4.0/releases/4.0/#features-removed-in-4-0) so this import statement needs updating.
Giesl
approved these changes
Jan 3, 2022
|
@Giesl thanks for the approval! I believe the Travis CI check won't complete because I submitted this during the AWS outage. I'd be happy to push an empty commit to trigger a new check, or whatever method you'd prefer. |
|
You can amend your commit with no changes with |
Giesl
approved these changes
Jan 5, 2022
Giesl
approved these changes
Jan 5, 2022
whob13
approved these changes
Jan 19, 2022
|
Is there a timeline to get this pushed to master? I'd like to update a project to Django 4 but will wait on this if it's coming soon. |
|
Hi All, I couldn't login to my github account for a while because of a sim card issue. I will tackle this along with other PRs in this week. Really sorry for the delay. |
erdem
approved these changes
Jan 26, 2022
|
FYI, I have published the 0.3.3 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 4.0 removed the ugettext_ family of functions so this import statement needs updating.