fix(els): continue analysis even if errors occur

erg-lang · Jun 16, 2024 · 2c9fe26 · 2c9fe26
1 parent 0b9b89a
commit 2c9fe26
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/crates/erg_compiler/build_package.rs b/crates/erg_compiler/build_package.rs
@@ -407,7 +407,7 @@ impl<ASTBuilder: ASTBuildable, HIRBuilder: Buildable>
             self.shared.warns.extend(self.parse_errors.warns.flush());
         // continue analysis if ELS mode
         } else if self.cfg.mode == ErgMode::LanguageServer {
-            self.finalize();
+            // self.finalize();
             self.shared.errors.extend(self.parse_errors.errors.flush());
             self.shared.warns.extend(self.parse_errors.warns.flush());
         } else {

diff --git a/crates/erg_compiler/context/inquire.rs b/crates/erg_compiler/context/inquire.rs
@@ -3179,7 +3179,8 @@ impl Context {
     }
 
     /// name: Identifier.inspect()
-    // FIXME: 現在の実装だとimportしたモジュールはどこからでも見れる
+    // FIXME: imported modules can access from any scope with the current implementation
+    // 現在の実装だとimportしたモジュールはどこからでも見れる
     pub(crate) fn get_mod(&self, name: &str) -> Option<&Context> {
         if name == "module" && ERG_MODE {
             self.get_module()