Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CC-BY-4.0 LICENSE for documentation and image #68

Merged
merged 39 commits into from
Aug 21, 2022
Merged

Add CC-BY-4.0 LICENSE for documentation and image #68

merged 39 commits into from
Aug 21, 2022

Conversation

C-BJ
Copy link
Member

@C-BJ C-BJ commented Aug 20, 2022

Unified with Webpage's LICENSE

@C-BJ C-BJ marked this pull request as draft August 20, 2022 02:30
@C-BJ C-BJ marked this pull request as ready for review August 20, 2022 02:30
@C-BJ C-BJ marked this pull request as draft August 20, 2022 03:04
@C-BJ C-BJ marked this pull request as ready for review August 20, 2022 03:07
@C-BJ C-BJ marked this pull request as draft August 20, 2022 03:47
@C-BJ C-BJ marked this pull request as ready for review August 20, 2022 03:50
@mtshiba
Copy link
Member

mtshiba commented Aug 20, 2022

Wouldn't this make it impossible for GitHub to identify licenses? @C-BJ

スクリーンショット 2022-08-20 212059

@C-BJ
Copy link
Member Author

C-BJ commented Aug 20, 2022

Wouldn't this make it impossible for GitHub to identify licenses? @C-BJ

スクリーンショット 2022-08-20 212059

Yes, do you have a better way?

@mtshiba
Copy link
Member

mtshiba commented Aug 21, 2022

Suppose someone considers using the Erg code base in the future. That person looks at the license notice on GitHub and may think, "Is this project using the original license? This looks like a hassle," and may give up without taking a closer look at the file.

And since the license probably doesn't need to be translated, there is no particular problem with leaving it in the directory root.

Also, it's enough to mention in the README that the documentation is provided under CC BY 4.0.

@C-BJ
Copy link
Member Author

C-BJ commented Aug 21, 2022

Suppose someone considers using the Erg code base in the future. That person looks at the license notice on GitHub and may think, "Is this project using the original license? This looks like a hassle," and may give up without taking a closer look at the file.

And since the license probably doesn't need to be translated, there is no particular problem with leaving it in the directory root.

Also, it's enough to mention in the README that the documentation is provided under CC BY 4.0.

It is worth mentioning that even if GitHub recognizes Apache 2.0, it may not be the source license, such as swift

@mtshiba
Copy link
Member

mtshiba commented Aug 21, 2022

Well, I think it would be better to know at a glance from the file name.

@mtshiba
Copy link
Member

mtshiba commented Aug 21, 2022

Wouldn't it be better to write what is written in LICENSE at the end of the README? That way, it can be translated into each language version and the cost of synchronization will not increase (instead of creating LICENSE files in different languages).

@C-BJ
Copy link
Member Author

C-BJ commented Aug 21, 2022

People only need to know that the code is MIT + Apache 2.0

@C-BJ
Copy link
Member Author

C-BJ commented Aug 21, 2022

People all over the world know the meaning of these two licenses

@mtshiba
Copy link
Member

mtshiba commented Aug 21, 2022

Of course that would be true, but I think the current situation displayed in the sidebar is better.
I only adopted the dual license in accordance with Rust's culture, I don't think that both must be displayed. As long as one or the other is displayed, it is fine.

@C-BJ
Copy link
Member Author

C-BJ commented Aug 21, 2022

Of course that would be true, but I think the current situation displayed in the sidebar is better. I only adopted the dual license in accordance with Rust's culture, I don't think that both must be displayed. As long as one or the other is displayed, it is fine.

Dual licenses are really better than MIT or Apache alone

@mtshiba
Copy link
Member

mtshiba commented Aug 21, 2022

Yes, it is. I was just mentioning the issue of only one of the licenses being displayed.

a

@C-BJ C-BJ marked this pull request as draft August 21, 2022 03:19
@C-BJ C-BJ marked this pull request as ready for review August 21, 2022 04:05
@mtshiba mtshiba merged commit 0ea3d94 into erg-lang:main Aug 21, 2022
@mtshiba
Copy link
Member

mtshiba commented Aug 21, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants