Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the wrong placement of pull_request_template.md #78

Merged
merged 2 commits into from
Aug 21, 2022
Merged

Change the wrong placement of pull_request_template.md #78

merged 2 commits into from
Aug 21, 2022

Conversation

C-BJ
Copy link
Member

@C-BJ C-BJ commented Aug 21, 2022

@mtshiba
Copy link
Member

mtshiba commented Aug 21, 2022

Placing it in the location would seem to allow for multiple PR templates (though I have only prepared one yet).

image

@C-BJ
Copy link
Member Author

C-BJ commented Aug 21, 2022

Placing it in the location would seem to allow for multiple PR templates (though I have only prepared one yet).

image

A single template should not be placed in a folder
Now it is invalid
@mtshiba

@C-BJ
Copy link
Member Author

C-BJ commented Aug 21, 2022

image
@mtshiba

@mtshiba
Copy link
Member

mtshiba commented Aug 21, 2022

Now I created a template for bug fix and that for implementing new features, is it still invalid?

@C-BJ
Copy link
Member Author

C-BJ commented Aug 21, 2022

Now I created a template for bug fix and that for implementing new features, is it still invalid?

Yes @mtshiba

@mtshiba
Copy link
Member

mtshiba commented Aug 21, 2022

I see. It seems that if there are multiple PR templates here, you have to add ?template=template_name.md to the PR creation URL.
This is a hassle, so let's not do this.

@mtshiba mtshiba merged commit 0865016 into erg-lang:main Aug 21, 2022
@C-BJ C-BJ deleted the patch-1 branch August 21, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants