Merge pull request #868 from ergebnis/fix/rector

Fix: Remove `rector/rector`

.github/CONTRIBUTING.md

@@ -46,18 +46,6 @@ make dependency-analysis
 
 to run a dependency analysis.
 
-## Refactoring
-
-We use [`rector/rector`](https://github.com/rectorphp/rector) to automatically refactor code.
-
-Run
-
-```sh
-make refactoring
-```
-
-to automatically refactor code.
-
 ## Security Analysis
 
 We use [`composer`](https://github.com/composer/composer) to run a security analysis.

.github/settings.yml

@@ -17,7 +17,6 @@ branches:
           - context: "Code Coverage (8.1, locked)"
           - context: "Coding Standards (8.1, locked)"
           - context: "Dependency Analysis (8.1, locked)"
-          - context: "Refactoring (8.1, locked)"
           - context: "Security Analysis (8.1, locked)"
           - context: "Static Code Analysis (8.1, locked)"
           - context: "Tests (8.1, highest)"

.github/workflows/integrate.yaml

@@ -198,65 +198,6 @@ jobs:
       - name: "Run maglnet/composer-require-checker"
         run: ".phive/composer-require-checker check --ansi --config-file=$(pwd)/composer-require-checker.json --verbose"
 
-  refactoring:
-    name: "Refactoring"
-
-    runs-on: "ubuntu-latest"
-
-    timeout-minutes: 5
-
-    strategy:
-      matrix:
-        php-version:
-          - "8.1"
-
-        dependencies:
-          - "locked"
-
-    steps:
-      - name: "Checkout"
-        uses: "actions/checkout@v4.2.2"
-
-      - name: "Set up PHP"
-        uses: "shivammathur/setup-php@2.31.1"
-        with:
-          coverage: "none"
-          extensions: "none, ctype, curl, dom, json, mbstring, phar, simplexml, tokenizer, xml, xmlwriter"
-          php-version: "${{ matrix.php-version }}"
-
-      - name: "Set up problem matchers for PHP"
-        run: "echo \"::add-matcher::${{ runner.tool_cache }}/php.json\""
-
-      - name: "Validate composer.json and composer.lock"
-        run: "composer validate --ansi --strict"
-
-      - name: "Determine composer cache directory"
-        uses: "ergebnis/.github/actions/composer/determine-cache-directory@1.9.2"
-
-      - name: "Cache dependencies installed with composer"
-        uses: "actions/cache@v4.1.2"
-        with:
-          path: "${{ env.COMPOSER_CACHE_DIR }}"
-          key: "php-${{ matrix.php-version }}-composer-${{ matrix.dependencies }}-${{ hashFiles('composer.lock') }}"
-          restore-keys: "php-${{ matrix.php-version }}-composer-${{ matrix.dependencies }}-"
-
-      - name: "Install ${{ matrix.dependencies }} dependencies with composer"
-        uses: "ergebnis/.github/actions/composer/install@1.9.2"
-        with:
-          dependencies: "${{ matrix.dependencies }}"
-
-      - name: "Cache cache directory for rector/rector"
-        uses: "actions/cache@v4.1.2"
-        with:
-          path: ".build/rector"
-          key: "php-${{ matrix.php-version }}-rector-${{ github.ref_name }}"
-          restore-keys: |
-            php-${{ matrix.php-version }}-rector-main
-            php-${{ matrix.php-version }}-rector-
-
-      - name: "Run automated refactoring with rector/rector"
-        run: "vendor/bin/rector --ansi --config=rector.php --dry-run"
-
   security-analysis:
     name: "Security Analysis"
 

Makefile

@@ -1,5 +1,5 @@
 .PHONY: it
-it: refactoring coding-standards security-analysis static-code-analysis tests ## Runs the refactoring, coding-standards, security-analysis, static-code-analysis, and tests targets
+it: coding-standards security-analysis static-code-analysis tests ## Runs the coding-standards, security-analysis, static-code-analysis, and tests targets
 
 .PHONY: code-coverage
 code-coverage: vendor ## Collects coverage from running integration tests with phpunit/phpunit
@@ -24,10 +24,6 @@ help: ## Displays this list of targets with descriptions
 phive: .phive ## Installs dependencies with phive
 	PHIVE_HOME=.build/phive phive install --trust-gpg-keys 0x033E5F8D801A2F8D
 
-.PHONY: refactoring
-refactoring: vendor ## Runs automated refactoring with rector/rector
-	vendor/bin/rector process --config=rector.php
-
 .PHONY: security-analysis
 security-analysis: vendor ## Runs a security analysis with composer
 	composer audit

composer.json

@@ -36,8 +36,7 @@
     "phpstan/phpstan-deprecation-rules": "^1.2.1",
     "phpstan/phpstan-strict-rules": "^1.6.1",
     "phpunit/phpunit": "^10.5.26",
-    "psr/container": "^2.0.2",
-    "rector/rector": "^1.2.10"
+    "psr/container": "^2.0.2"
   },
   "autoload": {
     "psr-4": {

phpstan.neon

@@ -24,7 +24,6 @@ parameters:
 		- test/
 		- .php-cs-fixer.fixture.php
 		- .php-cs-fixer.php
-		- rector.php
 
 	tmpDir: .build/phpstan/