Merge pull request #33 from ergebnis/fix/new

Fix: Avoid trailing new lines in report
ergebnis · Jan 25, 2021 · 3b019a0 · 3b019a0
2 parents 838b1b4 + 9260791
commit 3b019a0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/Reporter/DefaultReporter.php b/src/Reporter/DefaultReporter.php
@@ -56,6 +56,13 @@ public function report(SlowTest ...$slowTests): string
         $list = $this->list(...$slowTests);
         $footer = $this->footer(...$slowTests);
 
+        if ('' === $footer) {
+            return <<<TXT
+{$header}
+{$list}
+TXT;
+        }
+
         return <<<TXT
 {$header}
 {$list}

diff --git a/test/Unit/Reporter/DefaultReporterTest.php b/test/Unit/Reporter/DefaultReporterTest.php
@@ -168,7 +168,6 @@ public function testReportReturnsReportWhenTheNumberOfSlowTestsIsSmallerThanTheM
  3,456 ms: Ergebnis\PHPUnit\SlowTestDetector\Test\Example\SleeperTest::qux
  1,234 ms: Ergebnis\PHPUnit\SlowTestDetector\Test\Example\SleeperTest::quz
    123 ms: Ergebnis\PHPUnit\SlowTestDetector\Test\Example\SleeperTest::baz with dataset "string"
-
 TXT;
 
         self::assertSame($expected, $report);
@@ -259,7 +258,6 @@ public function testReportReturnsReportWhenTheNumberOfSlowTestsIsEqualToTheMaxim
  3,456 ms: Ergebnis\PHPUnit\SlowTestDetector\Test\Example\SleeperTest::qux
  1,234 ms: Ergebnis\PHPUnit\SlowTestDetector\Test\Example\SleeperTest::quz
    123 ms: Ergebnis\PHPUnit\SlowTestDetector\Test\Example\SleeperTest::baz with dataset "string"
-
 TXT;
 
         self::assertSame($expected, $report);