Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Rename Collector to Collector\DefaultCollector and extract Collector\Collector interface #24

Merged
merged 1 commit into from
Jan 24, 2021

Conversation

localheinz
Copy link
Member

This pull request

  • renames Collector to Collector\DefaultCollector and extracts a Collector\Collector interface

💁‍♂️ Useful for people who prefer to implement a different collector, for example

  • averaging
  • minimizing

The current - default - implementation picks the slowest test run for a given test when there are multiple test runs for the same tests. This usually happens when people run tests with the --repeat option, for example

$ vendor/bin/phpunit --repeat=100

@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Merging #24 (e75fb83) into main (6dc4bec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##                main       #24   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        38        38           
===========================================
  Files             10        10           
  Lines            141       140    -1     
===========================================
- Hits             141       140    -1     
Impacted Files Coverage Δ Complexity Δ
src/Collector/DefaultCollector.php 100.00% <ø> (ø) 5.00 <0.00> (?)
src/SlowTestCollector.php 100.00% <ø> (ø) 6.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc4bec...e75fb83. Read the comment docs.

@ergebnis-bot ergebnis-bot self-assigned this Jan 24, 2021
@ergebnis-bot ergebnis-bot merged commit 2289f1a into main Jan 24, 2021
@ergebnis-bot ergebnis-bot deleted the feature/rename branch January 24, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants