Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #[MaximumDuration] attribute #367

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Nov 17, 2023

This pull request

  • adds an #[MaximumDuration] attribute that works the same as the @maximumDuration annotation

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (56d3a10) 63.46% compared to head (46e7f00) 60.63%.

❗ Current head 46e7f00 differs from pull request most recent head 416eb76. Consider uploading reports for the commit 416eb76 to get more accurate results

Files Patch % Lines
src/Subscriber/TestPassedSubscriber.php 0.00% 20 Missing ⚠️
src/Attribute/MaximumDuration.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #367      +/-   ##
============================================
- Coverage     63.46%   60.63%   -2.83%     
- Complexity      102      110       +8     
============================================
  Files            21       22       +1     
  Lines           479      503      +24     
============================================
+ Hits            304      305       +1     
- Misses          175      198      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@localheinz localheinz self-assigned this Nov 18, 2023
@localheinz localheinz force-pushed the add-maximumduration-attribute branch 3 times, most recently from 3f48803 to 46e7f00 Compare November 27, 2023 12:43
@localheinz localheinz merged commit 207ad11 into ergebnis:main Nov 27, 2023
25 checks passed
@HypeMC HypeMC deleted the add-maximumduration-attribute branch November 27, 2023 12:45
@localheinz
Copy link
Member

Thank you, @HypeMC!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants