Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd PHP 7.4 and 8.0 support #371

Closed
wants to merge 6 commits into from
Closed

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Nov 22, 2023

fix #369

The purpose of this PR is to allow this package to be included in projects that still support PHP 7.4 and 8.0.

One release is required. Once released, it can be reverted, preferably after #368 is released as well.

Changes were done by Rector and were manually reviewed and tested on PHP 7.4 project on PHP 7.4 platform.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (4ac0501) 63.46% compared to head (247eaec) 63.59%.

Files Patch % Lines
src/Subscriber/TestPassedSubscriber.php 0.00% 4 Missing ⚠️
...bscriber/TestRunnerExecutionFinishedSubscriber.php 0.00% 3 Missing ⚠️
src/Subscriber/TestPreparedSubscriber.php 0.00% 2 Missing ⚠️
src/Extension.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #371      +/-   ##
============================================
+ Coverage     63.46%   63.59%   +0.13%     
  Complexity      102      102              
============================================
  Files            21       21              
  Lines           479      489      +10     
============================================
+ Hits            304      311       +7     
- Misses          175      178       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@localheinz
Copy link
Member

Closing in favour of #375 and #390.

Thank you, @mvorisek!

@localheinz localheinz closed this Dec 1, 2023
@mvorisek mvorisek deleted the php74_compat branch December 1, 2023 22:34
@mvorisek
Copy link
Contributor Author

mvorisek commented Dec 1, 2023

Sure, and thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with PHP 8.0 and lower
2 participants