Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve measurement details in README for phpunit 10+ #452

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mvorisek
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.86%. Comparing base (f7eadb6) to head (855834f).
Report is 261 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #452   +/-   ##
=========================================
  Coverage     69.86%   69.86%           
  Complexity      110      110           
=========================================
  Files            26       26           
  Lines           521      521           
=========================================
  Hits            364      364           
  Misses          157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mvorisek
Copy link
Contributor Author

Firstly, thank you for merging the #380 PR!

I did my best to improve the README for new users, especially to stress:

  • the before/after class test methods are measured only when phpunit process isolation is enabled
  • remove the notes telling the durations might vary on a tests order, this is not true

@localheinz localheinz self-assigned this Jan 15, 2024
@mvorisek
Copy link
Contributor Author

@localheinz is this PR welcomed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants