Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Implement MaximumDuration #46

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

localheinz
Copy link
Member

This pull request

  • implements MaximumDuration as a value object

💁‍♂️ It's perhaps a little bit more convenient to use.

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #46 (e6bd9ba) into main (7c85a95) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #46      +/-   ##
============================================
+ Coverage     99.43%   99.50%   +0.06%     
- Complexity       43       50       +7     
============================================
  Files            11       13       +2     
  Lines           178      202      +24     
============================================
+ Hits            177      201      +24     
  Misses            1        1              
Impacted Files Coverage Δ Complexity Δ
src/Exception/InvalidMaximumDuration.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)
src/MaximumDuration.php 100.00% <100.00%> (ø) 6.00 <6.00> (?)
src/Reporter/DefaultReporter.php 100.00% <100.00%> (ø) 12.00 <0.00> (ø)
src/Subscriber/TestPassedSubscriber.php 100.00% <100.00%> (ø) 3.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c85a95...e6bd9ba. Read the comment docs.

@ergebnis-bot ergebnis-bot self-assigned this Jan 26, 2021
@ergebnis-bot ergebnis-bot merged commit 1df12ef into main Jan 26, 2021
@ergebnis-bot ergebnis-bot deleted the feature/maximum-duration branch January 26, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants