Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Explicitly include src/ directory when compiling PHAR #598

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Sep 5, 2024

This pull request

  • removes the autoload configuration before running tests with PHAR
  • explicitly includes the src/ directory when compiling PHAR because humbug/box apparently filters out directories named Test

@localheinz localheinz self-assigned this Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.88%. Comparing base (0019770) to head (c561045).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #598   +/-   ##
=========================================
  Coverage     61.88%   61.88%           
  Complexity      116      116           
=========================================
  Files            28       28           
  Lines           585      585           
=========================================
  Hits            362      362           
  Misses          223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@localheinz localheinz force-pushed the fix/autoload branch 2 times, most recently from 84694de to b8b7452 Compare September 5, 2024 07:21
@localheinz localheinz changed the title Fix: Actually remove autoloader before running tests with PHAR Fix: Remove autoload configuration before running tests with PHAR Sep 5, 2024
@localheinz localheinz changed the title Fix: Remove autoload configuration before running tests with PHAR Fix: Explicitly include src/ directory when compiling PHAR Sep 5, 2024
@localheinz localheinz merged commit 68326d5 into main Sep 5, 2024
63 checks passed
@localheinz localheinz deleted the fix/autoload branch September 5, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants