gh-620: Explicitly include InstalledVersions.php and installed.php in PHAR
#621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #621 +/- ##
=========================================
Coverage 56.10% 56.10%
Complexity 116 116
=========================================
Files 28 28
Lines 672 672
=========================================
Hits 377 377
Misses 295 295 ☔ View full report in Codecov by Sentry. |
…lled.php` in PHAR The autoloadmap includes a mapping `Composer\InstalledVersions` but as of explicitly including `src` this file is no longer included. This commit explicitly adds both `vendor/composer/InstalledVersions.php` and `vendor/composer/installed.php` to ensure that the previous behavior is preserved and WARNINGS are not issued when other packages use `InstalledVersions::getVersion(// ...)`.
localheinz
approved these changes
Oct 25, 2024
|
Thank you, @dantleech! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autoloadmap includes a mapping
Composer\InstalledVersionsbut as of explicitly includingsrcthis file is no longer included.This commit explicitly adds both
vendor/composer/InstalledVersions.phpandvendor/composer/installed.phpto ensure that the previous behavior is preserved and WARNINGS are not issued when other packages useInstalledVersions::getVersion(// ...).Related to #620
Fixes #620