Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support proxy protocol v2 #1389

Closed
slingamn opened this issue Nov 18, 2020 · 1 comment · Fixed by #1391
Closed

support proxy protocol v2 #1389

slingamn opened this issue Nov 18, 2020 · 1 comment · Fixed by #1391
Milestone
v2.5

Comments

@slingamn
Copy link
Member

Looks like AWS is using this exclusively:

https://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-target-groups.html

so we should support it. In particular, we should support it ahead of a plaintext connection.
@slingamn slingamn added this to the v2.5 milestone Nov 18, 2020
@DanielOaks
Copy link
Member

Urgh. Yeah V1 is text-only, v2 is binary-only. https://www.haproxy.org/download/1.8/doc/proxy-protocol.txt

slingamn added a commit to slingamn/ergo that referenced this issue Nov 18, 2020
@slingamn
fix ergochat#1389
53a8195 
Support PROXY protocol v2, including ahead of plaintext connections
slingamn added a commit to slingamn/ergo that referenced this issue Nov 18, 2020
@slingamn
fix ergochat#1389
9fef0b0 
Support PROXY protocol v2, including ahead of plaintext connections
slingamn added a commit to slingamn/ergo that referenced this issue Nov 18, 2020
@slingamn
fix ergochat#1389
8ae51d5 
Support PROXY protocol v2, including ahead of plaintext connections
slingamn added a commit to slingamn/ergo that referenced this issue Nov 19, 2020
@slingamn
fix ergochat#1389
3062f97 
Support PROXY protocol v2, including ahead of plaintext connections
@slingamn slingamn linked a pull request Nov 19, 2020 that will close this issue
fix #1389 #1391
Merged
slingamn added a commit that referenced this issue Nov 19, 2020
@slingamn
Merge pull request #1391 from slingamn/proxy.3
f30bd2c 
fix #1389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5
Development

Successfully merging a pull request may close this issue.

fix #1389 slingamn/ergo
2 participants
@DanielOaks @slingamn