implement candidate compromise proposal for websockets #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Text and binary frames are accepted 2. Text frames are sent by default 3. Binary frames are sent to clients who negotiate `binary.ircv3.net` 4. Non-UTF8 data is not accepted (enabling websockets still enables UTFONLY)
As of ergochat#1483, websockets entail enforce-utf8, so there's no need to check globalUTF8EnforcementSetting when handling websockets.
|
This also implements proposal 3 ("binary baseline"). |
|
Actually, this also works with the original proposal that had "consensus" (subprotocols, no interoperable baseline). So I'm just going to merge it. |
|
Specifically, this implements 20089b17d7151 on ircv3/ircv3-specifications#342 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binary.ircv3.net