deprecate message truncation #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements ergochat#1577, but the issue should remain open until we clean up the debugging loglines.
|
This will also close #1575; regardless of the value of the new setting, this version of ircmsg will never truncate a valid UTF-8 message in the middle of a codepoint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1577, but the issue should remain open until we clean up the debugging loglines.
This splits the baby:
default.yamlhasallow-truncation: false(and I plan for the test suite to run in this mode), buttraditional.yamlhas it astrue, and it will default to true when unset (so no one gets surprised by their bots breaking).