Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing IT tests #2129

Closed
wants to merge 14 commits into from
Closed

Fixing IT tests #2129

wants to merge 14 commits into from

Conversation

ccellado
Copy link
Collaborator

@ccellado ccellado commented Feb 28, 2024 •
edited
Loading

Fixes #653 #1564 #1160

@ccellado ccellado mentioned this pull request Feb 28, 2024
Closed
@ccellado
Copy link
Collaborator Author

#2128 (comment)

Fetched your docker-fix branch: a similar error (within IntelliJ)

P:\work\ergo\src\it\scala\org\ergoplatform\it\DeepRollBackSpec.scala:52:44
The async requires the compiler option -Xasync (supported only by Scala 2.12.12+ / 2.13.3+)
    val result: Future[Unit] = Async.async

(cli complile via sbt it:compile it2:compile works though)

IT tests are meant to run outside IDEA anyways, so fixing for it is lower priority

@stenolog stenolog mentioned this pull request Feb 29, 2024
Closed
@ccellado
Copy link
Collaborator Author

ccellado commented Mar 1, 2024

(cli complile via sbt it:compile it2:compile works though)

IT tests are meant to run outside IDEA anyways, so fixing for it is lower priority

Not running the tests in idea, just the main build

Reproduction

  • checkout branch
  • open ergo with an IntellJ IDEA Community, fresh install
  • MENU -> Build -> Build Project

IDEA not respecting sbt config, so tick that box and project builds fine

image

@ccellado
Copy link
Collaborator Author

ccellado commented Mar 1, 2024

Readme updated

@stenolog stenolog mentioned this pull request Mar 7, 2024
Closed
@ccellado ccellado marked this pull request as ready for review March 16, 2024 22:04
kushti and others added 13 commits March 17, 2024 02:25
@kushti @ccellado
5.0.21 version set
9d768e8
@ccellado
Refactor Message class
e4637d7 
Add changes to ergo-core readme
@ccellado
Refactor Message class
e5638fc 
Add changes to ergo-core readme
@ccellado
Better wallet unlock error
9df0354
@ccellado
Better wallet unlock error
5acd023
@ccellado
Better wallet unlock error
310b821
@deadit @ccellado
add burn tokens form to ergo-node-interface
052694b
@ccellado
Move tests to ergo-core
edc8f30 
extract PoPowAlgosSpec -> PoPowAlgosWithDBSpec

extract SerializationTest -> SerializationCoreTest

extract JsonSerializationSpec -> JsonSerializationCoreSpec

move scorex.testkit.SerializationTests -> ergo-core/org.ergoplatform/utils

NiPoPoWVerifierSpec has to stay in node's test since ChainGenerators it requires uses ErgoHistory

Create ChainSettingsReader in ergocore

Refactor generators to use Object instead of trait. To avoid OOP inheritance spagetti

Remove scores.testkit.CoreGenerators

Move scorex.testkit.generators.ObjectGenerators -> ergo-core/org.ergoplatform.utils.generators.CoreGenerators

Extract ergo-node specific ConnectedPeerGenerators from CoreGenerators

Move DefaultFakePowScheme to ergo-core

Dissect ErgoTestConstants into ErgoCoreTestConstants & ErgoNodeTestConstants

Move settings.LaunchParameters to ergo-core

Dissect ErgoTransactionGenerators into ErgoCoreTransactionGenerators & ErgoNodeTransactionGenerators

Dissect part of VotingSpecification to ErgoNodeVotingSpecification
@ccellado
Move tests to ergo-core
dba4ff7 
extract PoPowAlgosSpec -> PoPowAlgosWithDBSpec

extract SerializationTest -> SerializationCoreTest

extract JsonSerializationSpec -> JsonSerializationCoreSpec

move scorex.testkit.SerializationTests -> ergo-core/org.ergoplatform/utils

NiPoPoWVerifierSpec has to stay in node's test since ChainGenerators it requires uses ErgoHistory

Create ChainSettingsReader in ergocore

Refactor generators to use Object instead of trait. To avoid OOP inheritance spagetti

Remove scores.testkit.CoreGenerators

Move scorex.testkit.generators.ObjectGenerators -> ergo-core/org.ergoplatform.utils.generators.CoreGenerators

Extract ergo-node specific ConnectedPeerGenerators from CoreGenerators

Move DefaultFakePowScheme to ergo-core

Dissect ErgoTestConstants into ErgoCoreTestConstants & ErgoNodeTestConstants

Move settings.LaunchParameters to ergo-core

Dissect ErgoTransactionGenerators into ErgoCoreTransactionGenerators & ErgoNodeTransactionGenerators

Dissect part of VotingSpecification to ErgoNodeVotingSpecification
@stenolog @ccellado
fix ErgoStateContextSpec sporadic failure
9d9a239 
fix test 'valid application of correct extension'

fix test 'validation of field value sizes'
@stenolog @ccellado
provide alternate test-generators
578c891
@ccellado
Fix ergo-core publishing in build.sbt
762372c 
Add ergo-core testing and publishing snapshot on PR branch push
@ccellado
Fix ergo-core multiversion tests
6bb0030
@ccellado
Remove old docker library
6364e38 
Fix integration specs
Deprecate OpenApiSpec
@ccellado
Copy link
Collaborator Author

Dirty tree, closed in favor of #2139

@ccellado ccellado closed this Mar 16, 2024
@ccellado ccellado deleted the docker-fix branch March 16, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ccellado @kushti @deadit @stenolog