Use cache in HistoryStorage #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catena2w
force-pushed
the
i332
branch
3 times, most recently
from
98ab4fb to
0d5cc14
Compare
kushti
reviewed
Jul 17, 2018
lock.sbt
Outdated
| "com.google.code.findbugs" % "jsr305" % "1.3.9", | ||
| "com.google.errorprone" % "error_prone_annotations" % "2.1.3", | ||
| "com.google.guava" % "guava" % "25.1-jre", | ||
| "com.google.j2objc" % "j2objc-annotations" % "1.1", |
There was a problem hiding this comment.
Ain't we going to add a lot of dependencies to just use some trivial FP sugar? I would like to propose to use Guava directly.
kushti
approved these changes
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.