Test for block with invalid extension application. #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-aksarin
reviewed
Oct 8, 2018
|
|
||
| applyBlock(block) shouldBe 'success | ||
| getBestHeaderOpt shouldBe Some(block.header) | ||
| if (verifyTransactions) { |
There was a problem hiding this comment.
double verifyTransactions check
| @@ -368,7 +409,7 @@ class ErgoNodeViewHolderSpec extends ErgoPropertyTest with NodeViewTestOps with | |||
| } | |||
| } | |||
|
|
|||
| val verifyingTxCases = List(t10, t11, t12, t13) | |||
| val verifyingTxCases = List(t11, t12, t13, t14) | |||
There was a problem hiding this comment.
Maybe we should also move t7 and t8 here?
oskin1
added
S-ready-for-merge
|
Depends on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#483