UI improvements #26
Merged
UI improvements #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed Transaction Amount - renamed P2PK Signing > Start Signing - renamed Address > To - renamed Output Value > Amount - renamed Transaction Fee > Fee - (stax/flex) renamed Approve Signing > Sign transaction - (nano s+/x) sign transcation: changed Approve > Sign transaction
arobsn
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Awesome job! Everything works as described in the issues.
However, there are two small tweaks that weren't described by the issues that are goo to have on Stax and Flex devices:
-
Use the same
verify addresstemplate forexport address:
1.1 RenameAddress ExporttoExport Ergo address,
1.2 use the Ergo icon, and
1.3 sayAddress exportedwhen the user confirms. -
Rename
Ext PubKey ExporttoExport Ergo public keyand use the Ergo icon.
Can you please do these additional changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
developRenamed
Token ValuetoToken Raw Value, ref: #21Changed home page text, address verification ux, removed usage of streaming API, ref: #22
Changed signing flow for nano x/s+ according to #23:
Closes #21
Closes #22
Closes #23