Pull rsp rebase #122
Closed
Pull rsp rebase #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix bug in rsp add rsp sync push race condition for push fix bug in rsp pull. refactor test cleanup comments refactor dist server fix lint fix storage shape issue with the new ndarray constructor
add test. fix return type
sparse pull c_api revise rowsparse pull api use engine to compute unique to ensure thread safety add rowsparse pull to dist-kv
* update kvstore unit test * update model/module.py * fix lint * remove int keys in kvstore * update cast to str function * remove _cast_to_str_keys * fix lint * always cast to str Conflicts: include/mxnet/c_api.h include/mxnet/kvstore.h python/mxnet/kvstore.py python/mxnet/model.py python/mxnet/module/module.py src/c_api/c_api.cc src/kvstore/kvstore_local.h tests/python/unittest/test_kvstore.py
eric-haibin-lin
pushed a commit
that referenced
this pull request
Apr 4, 2018
* Handling duplicate NodeEntries on the edge of the graph * Fix docs and segfault * Suggestions from review * Added attr_parser check
eric-haibin-lin
pushed a commit
that referenced
this pull request
Dec 9, 2019
* tf: enable async training * tf: quick fix * tf: override minimize() * tf: fix args * tf: reformat and fix GATE_OP * tf: improve comment * docs: update readme * tf: fix get gradient * tf: fix sync train * tf: attempt to fix sync train * tf: add dependency control * tf: nit * tf: use dump_op * tf: quick fix * tf: quick fix * tf: use group * docs: add async env * tf: improvement on override * tf: avoid override minimize() * tf: quick fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR for interface review:
row_sparse_pullpython API to kvstore and c_api, which requires providingrow_idfor each row_sparse value to pull. Therow_ids are sorted to contain only unique elements. The oldpullAPI will not accept pulling a row_sparse value storedsparse_pull_dictparam to module so that user can specify the subset of rows to pull for next batch during trainingkRowSparsePushPulltype to kvstore server. When received data request of this type, keys are encoded askey, row_id1, row_id2 ... row_idn.row_sparse_pull: https://github.com/eric-haibin-lin/benchmark/blob/sparse/mx/sparse_regression.py#L168Note:
TODOs for next PR: