Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add clarification for csr #182

Merged
merged 2 commits into from
Aug 21, 2017
Merged

add clarification for csr #182

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f944122
add clarification for csr
eric-haibin-lin Aug 21, 2017
b0fa268
cr comments
eric-haibin-lin Aug 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions python/mxnet/ndarray/sparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,9 @@ class CSRNDArray(BaseSparseNDArray):
row i are stored in indices[indptr[i]:indptr[i+1]] and their corresponding values are stored
in values[indptr[i]:indptr[i+1]].

The indices are expected to be sorted per row in ascending order. Duplicate matrix entries are
Copy link

@cjolivier01 cjolivier01 Aug 21, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should it be 'duplicate column entries for the same row'?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "The column indices for a given row are expected to be in ascending order..."

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

not allowed.

Example
-------
>>> a = mx.nd.array([[0, 1, 0], [2, 0, 0], [0, 0, 0], [0, 0, 3]])
Expand Down