Skip to content
This repository has been archived by the owner on Nov 19, 2020. It is now read-only.

fix pluralization for resources ending in 's', and 'y' #88

Merged
merged 2 commits into from
May 29, 2018
Merged

fix pluralization for resources ending in 's', and 'y' #88

merged 2 commits into from
May 29, 2018

Conversation

hoskeri
Copy link
Contributor

@hoskeri hoskeri commented May 29, 2018

Some of the pluralizations were wrong, fixed them and verified it with the upstream swagger.json

ericchiang
ericchiang approved these changes May 29, 2018
View reviewed changes
Copy link
Owner

@ericchiang ericchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

I'll merge on green

@ericchiang
Copy link
Owner

Actually I can already tell that you're going to need to run

make generate

before sending this change

@hoskeri
Copy link
Contributor Author

hoskeri commented May 29, 2018

I was not sure if you wanted to generate them yourself - but I have pushed the regenerated files as well.

@ericchiang
Copy link
Owner

lgtm

thanks!

@ericchiang ericchiang merged commit 7f7ccea into ericchiang:master May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericchiang ericchiang ericchiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoskeri @ericchiang