Option to use SIGKILL when stopping server #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you help with #98? |
|
Would be happy to. |
|
@jlsutherland You're all set! 🎉 |
|
Woot! |
This was referenced Dec 16, 2015
Closed
Closed
|
Any idea when this fix will be merged and published to npm? |
jlsutherland
added a commit
that referenced
this pull request
Feb 14, 2016
Option to use SIGKILL when stopping server
|
Sorry for the late response on this, thanks for your efforts and addressing this issue 😄 |
|
Welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remedies an issue where the node process spawned by grunt ignores
SIGTERM, failing to shut down and generating the errorEADDRINUSE(see, e.g., #14).The PR integrates an option called
hardStop, passable via the usual options json, to send theSIGKILLcommand instead ofSIGTERMwhen stopping the spawned process.