Move Semgrep into separate workflow #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate the continuous Semgrep job from the general checks workflow. The motivation for this is that semgrep requires access to a secret to work, and this secret isn't available on Pull Requests from forks. This leads in a failed pipeline for external contributors, which is not desired. Hence, just run it on main and address problems it finds separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #734, #772, #775, #991
Summary
Separate the continuous Semgrep job from the general checks workflow. The motivation for this is that semgrep requires access to a secret to work, and this secret isn't available on Pull Requests from forks. This leads in a failed pipeline for external contributors, which is not desired. Hence, just run it on main and address problems it finds separately.