Crossover and degradation checks #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 91.09% 91.17% +0.08%
==========================================
Files 4 4
Lines 550 555 +5
==========================================
+ Hits 501 506 +5
Misses 49 49 ☔ View full report in Codecov by Sentry. |
ericfell
reviewed
Jan 19, 2024
| @@ -524,13 +524,19 @@ def _validate_protocol( | |||
| if cell_model.init_ocv > 0.0 > self.voltage_limit_discharge: | |||
| raise ValueError("Ensure that 'voltage_limit_discharge' >= 0.0 when 'init_ocv' > 0.0") | |||
|
|
|||
| if crossover and cell_model.init_ocv > 0.0: | |||
There was a problem hiding this comment.
looks good, and passes new tests
ericfell
reviewed
Jan 19, 2024
| if degradation is not None and (cls_degradation is not None or ncls_degradation is not None): | ||
| raise ValueError("Cannot specify both 'degradation' and '(n)cls_degradation'") | ||
|
|
||
| if degradation is not None: | ||
| cls_degradation = degradation | ||
| ncls_degradation = degradation | ||
|
|
||
| cls_degradation = copy.deepcopy(cls_degradation) |
There was a problem hiding this comment.
looks good, but do we want a small comment here explaining why we use a deepcopy?
ericfell
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.