WIP: refactor!: remove unnecessary fields in `RenderPipelineDescripto…

…r` builder usage
erichdongubler-mozilla · Sep 20, 2024 · 2088ac8 · 2088ac8
1 parent 38060c0
commit 2088ac8
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 18 deletions.
diff --git a/benches/benches/renderpass.rs b/benches/benches/renderpass.rs
@@ -174,7 +174,6 @@ impl RenderpassState {
 
         let pipeline = device_state.device.create_render_pipeline(
             &wgpu::RenderPipelineDescriptor::builder()
-                .label(None)
                 .layout(&pipeline_layout)
                 .vertex(
                     wgpu::VertexState::from_module(&sm)
@@ -188,8 +187,6 @@ impl RenderpassState {
                         .cull_mode(wgpu::Face::Back)
                         .build(),
                 )
-                .maybe_depth_stencil(None)
-                .multisample(Default::default())
                 .fragment(
                     wgpu::FragmentState::from_module(&sm)
                         .entry_point("fs_main")
@@ -200,8 +197,6 @@ impl RenderpassState {
                         )])
                         .build(),
                 )
-                .maybe_multiview(None)
-                .maybe_cache(None)
                 .build(),
         );
 
@@ -262,7 +257,6 @@ impl RenderpassState {
             bindless_pipeline = Some(
                 device_state.device.create_render_pipeline(
                     &wgpu::RenderPipelineDescriptor::builder()
-                        .label(None)
                         .layout(&bindless_pipeline_layout)
                         .vertex(
                             wgpu::VertexState::from_module(&bindless_shader_module)
@@ -276,8 +270,6 @@ impl RenderpassState {
                                 .cull_mode(wgpu::Face::Back)
                                 .build(),
                         )
-                        .maybe_depth_stencil(None)
-                        .multisample(Default::default())
                         .fragment(
                             wgpu::FragmentState::from_module(&bindless_shader_module)
                                 .entry_point("fs_main")
@@ -288,8 +280,6 @@ impl RenderpassState {
                                 )])
                                 .build(),
                         )
-                        .maybe_multiview(None)
-                        .maybe_cache(None)
                         .build(),
                 ),
             );

diff --git a/examples/src/water/mod.rs b/examples/src/water/mod.rs
@@ -549,11 +549,6 @@ impl crate::framework::Example for Example {
                         )])
                         .build(),
                 )
-                // No multisampling is used.
-                .multisample(Default::default())
-                .maybe_multiview(None)
-                // No pipeline caching is used
-                .maybe_cache(None)
                 .build(),
         );
 
@@ -586,9 +581,6 @@ impl crate::framework::Example for Example {
                     .depth_compare(wgpu::CompareFunction::Less)
                     .build(),
             )
-            .multisample(Default::default())
-            .maybe_multiview(None)
-            .maybe_cache(None)
             .build()
         );