Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some compiler warnings #253

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Conversation

dotsam
Copy link

@dotsam dotsam commented Aug 11, 2023

  • Fix syntax of a cast to a uint32
  • Remove defines that are already made by the base platform

Cleans up platform.io compile output quite a bit, making it much easier to spot other errors/warnings, of which there is still one, but I'm not sure if it's legitimate, and if so, how to fix it:

src/BlueSCSI.cpp: In function 'void longjmpFromInterrupt(int*, int)':
src/BlueSCSI.cpp:790:1: warning: 'noreturn' function does return
  790 | }
      | ^

 - Fix syntax of a cast to a uint32
 - Remove defines that are already made by the base platform
@erichelgeson erichelgeson merged commit 4f7c0fe into erichelgeson:main Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants