Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported Distributions #7

Closed
jknox13 opened this issue May 13, 2018 · 1 comment
Closed

Supported Distributions #7

jknox13 opened this issue May 13, 2018 · 1 comment

Comments

@jknox13
Copy link
Collaborator

jknox13 commented May 13, 2018

Standardize the set of sampling distributions. As of now we use the following:

  • 'guassian' or 'normal': np.random.standard_normal
  • 'uniform': np.random.uniform(-1, 1)
  • 'None': np.random.rand
    And also from csvd
  • 'spixel': random sampling of rows
  • 'sparse': np.sparse.rand

After we agree on the set of sampling distributions, we can incorporate them into
the sketch function to reduce code repetition and limit the set of distributions
on an algorithm by algorithm basis if needed (i.e. if rsvd and rdmd
should not have the same set of distributions available).

@erichson
Copy link
Owner

Yes, that is a great idea to unify the sketch functionality across all functions. It will us also allow to easily add some additional sketching schemes in a future version.

erichson added a commit that referenced this issue May 26, 2018
Fixes #7 via sketch module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants