Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not needed padding on tabs on dev version #10

Closed
lisovyk opened this issue May 31, 2017 · 4 comments
Closed

Not needed padding on tabs on dev version #10

lisovyk opened this issue May 31, 2017 · 4 comments

Comments

@lisovyk
Copy link

lisovyk commented May 31, 2017

Sample:

library(shinymaterial)

ui <- material_page(
    material_tabs(
        tabs = c(
            "tab" = "first_tab",
            "tab" = "second_tab"
        )
    )
)
server <- function(input, output) {}
shinyApp(ui = ui, server = server)

On current dev version there is not intended(i guess?) padding on the material_tabs. See the sample above.
In the sample, there is a div with col s12 offset-s0 class. It has padding: 0 .75rem; that causes tabs to not fill the whole width of the page.

@ericrayanderson
Copy link
Owner

That was intended. I went back and forth on which way to do it. I figured most people would want things off the edges, at the cost of flexibility. But, that may not be the case.

@lisovyk
Copy link
Author

lisovyk commented Jun 15, 2017

Uh, I dont know. It doesn't seem good imo. Maybe that's only my preferences.

@jbkunst
Copy link

jbkunst commented Jun 15, 2017

Hi everyone,

My 1 1/2 cents: In my particular case, I've changed previously the defaults in the package I maintain because IMHO it's better 😅 , but sometimes it's good be consistent with the library/framework/etc we're porting to R i.e. keep the defaults intact.

(jbkunst/highcharter#272)

@ericrayanderson
Copy link
Owner

Padding has been removed (beginning with v_0.3.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants