Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect default value for hc_opts$plotOptions$bubble$maxSize #272

Closed
joh024 opened this issue Feb 20, 2017 · 4 comments
Closed

Incorrect default value for hc_opts$plotOptions$bubble$maxSize #272

joh024 opened this issue Feb 20, 2017 · 4 comments

Comments

@joh024
Copy link

joh024 commented Feb 20, 2017

The default per the official highcharts API is "20%" but currently highcharter has it set to 25.

This fixed pixel maximum will frequently break large bubble charts with the user having no idea why until they discover the default is different in highcharter after trial and error.

@jbkunst
Copy link
Owner

jbkunst commented Feb 21, 2017

Hi @joh024
Yeah, I abused and override the default with my taste. Maybe this is not a good options so I remove them ;)!

Thanks as always.

@jbkunst jbkunst added this to the v0.5.1 milestone Feb 21, 2017
jbkunst added a commit that referenced this issue Feb 21, 2017
@jbkunst
Copy link
Owner

jbkunst commented Feb 22, 2017

Don't you think they look too big?

hchart(cars, "point", hcaes(dist, speed, size = speed))

image

hchart(cars, "point", hcaes(dist, speed, size = speed), maxSize = "10%")

image

@joh024
Copy link
Author

joh024 commented Feb 22, 2017

That's why it's an argument, so if someone feels it's too big they can set a lower maximum. But I'd say the defaults should be consistent with highcharts.

@jbkunst
Copy link
Owner

jbkunst commented Feb 22, 2017

Ok, sounds good. The change to defaults was made. Thanks again 😉 ,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants