Skip to content

Commit

Permalink
Fix invalid URIs from README and make CRAN comment
Browse files Browse the repository at this point in the history
  • Loading branch information
erictleung committed Jul 27, 2021
1 parent 32eda4b commit c9dfdf0
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 12 deletions.
10 changes: 5 additions & 5 deletions README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ This data here within is not constrained to exploring just within R.
Here are other accessible means of using this data.

- Through [your browser](https://pixarfilms-datasette.herokuapp.com/pixarfilms)
using datasette and [a SQLite database](./data-raw/pixarfilms.db)
- Through CSV files found within the [`data-raw/` directory](./data-raw/)
using datasette and a SQLite database (located at `/data-raw/pixarfilms.db`).
- Through CSV files found within the `data-raw/` directory.

Here are direct links to each data set.

Expand All @@ -87,9 +87,9 @@ https://raw.githubusercontent.com/erictleung/pixarfilms/master/data-raw/pixar_pe
https://raw.githubusercontent.com/erictleung/pixarfilms/master/data-raw/public_response.csv
```

There's also [a `datapackage.json` file](./data-raw/datapackage.json) to be a
computer-readable data dictionary describing the contents of each data file as
described in
There's also a `datapackage.json` file (located at `/data-raw/datapackage.json`)
to be a computer-readable data dictionary describing the contents of each data
file as described in
[the data package specifications](https://specs.frictionlessdata.io/data-package/).


Expand Down
13 changes: 7 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,9 @@ Here are other accessible means of using this data.

- Through [your
browser](https://pixarfilms-datasette.herokuapp.com/pixarfilms)
using datasette and [a SQLite database](./data-raw/pixarfilms.db)
- Through CSV files found within the [`data-raw/`
directory](./data-raw/)
using datasette and a SQLite database (located at
`/data-raw/pixarfilms.db`).
- Through CSV files found within the `data-raw/` directory.

Here are direct links to each data set.

Expand All @@ -95,9 +95,10 @@ Here are direct links to each data set.
https://raw.githubusercontent.com/erictleung/pixarfilms/master/data-raw/pixar_people.csv
https://raw.githubusercontent.com/erictleung/pixarfilms/master/data-raw/public_response.csv

There’s also [a `datapackage.json` file](./data-raw/datapackage.json) to
be a computer-readable data dictionary describing the contents of each
data file as described in [the data package
There’s also a `datapackage.json` file (located at
`/data-raw/datapackage.json`) to be a computer-readable data dictionary
describing the contents of each data file as described in [the data
package
specifications](https://specs.frictionlessdata.io/data-package/).

## Feedback
Expand Down
6 changes: 5 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
0 errors √ | 0 warnings √ | 0 notes √

## Errors addressed from previous submission
The following warning was received:

Found the following (possibly) invalid file URIs:
URI: erictleung.com/pixarfilms/
From: README.md
Expand All @@ -18,4 +20,6 @@ Found the following (possibly) invalid file URIs:
URI: data-raw/datapackage.json
From: README.md

The above file URIs are updated to be valid in their corresponding files.
The above file URIs are updated to be valid in their corresponding files and is
reflected in the winbuilder report
https://win-builder.r-project.org/c6PFgDQi2zOn/00check.log

0 comments on commit c9dfdf0

Please sign in to comment.