Spliting snap.stop logic to e2 and e3 parts: snap.stop/snap.state.stop (corresponds to ProduceE2 and ProduceE3) #10622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2024 11:13
…ogic in freezing files in snapshot
|
Linked issue: #10318 |
AskAlexSharov
requested changes
Jun 5, 2024
eth/stagedsync/stage_snapshots.go
Outdated
|
|
||
| var minBlockNumber uint64 | ||
|
|
||
| if cfg.snapshotUploader != nil { | ||
| minBlockNumber = cfg.snapshotUploader.minBlockNumber() | ||
| } | ||
|
|
||
| if s.CurrentSyncCycle.IsInitialCycle { | ||
| if s.CurrentSyncCycle.IsFirstCycle { |
There was a problem hiding this comment.
this part is not related to current PR. let's move it to another one
eth/ethconfig/config.go
Outdated
| @@ -136,7 +137,8 @@ func init() { | |||
| type BlocksFreezing struct { | |||
| Enabled bool | |||
| KeepBlocks bool // produce new snapshots of blocks but don't remove blocks from DB | |||
| Produce bool // produce new snapshots | |||
| ProduceE2 bool // produce new snapshots | |||
There was a problem hiding this comment.
produce new snapshots -> produce new blocks files
AskAlexSharov
approved these changes
Jun 12, 2024
AskAlexSharov
changed the title
AskAlexSharov
approved these changes
Jun 13, 2024
AskAlexSharov
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split Produce flag to ProduceE2 and ProduceE3 flag. Also replaced a logic in freezing files in snapshot. Added produce flag and it's setter to an aggregator. Closes #10318