Refactor logsFilter to prevent concurrent map fatal errors (#10672) #11892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #11890
cherry pick from E3 2f2ce6afaa67d6d013bf7d785ed88557e8a9cc21
Issue:
At line 129 in
logsfilter.go
, we had the following line of code:This line caused a panic due to a fatal error:
This error indicates that there were simultaneous read and write operations on the
filter.addrs
map, leading to a race condition.Solution:
To resolve this issue, I implemented the following changes: