Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type of error field in structlog logger differs from geth, alloy #12089

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Type of error field in structlog logger differs from geth, alloy #12089

merged 1 commit into from
Oct 1, 2024

Conversation

AskAlexSharov
Copy link
Collaborator

@AskAlexSharov AskAlexSharov commented Sep 25, 2024 •
edited
Loading

@AskAlexSharov AskAlexSharov mentioned this pull request Sep 25, 2024
Closed
@AskAlexSharov AskAlexSharov enabled auto-merge (squash) September 25, 2024 11:46
@einar-polygon einar-polygon mentioned this pull request Sep 30, 2024
Open
@AskAlexSharov AskAlexSharov merged commit 7086799 into main Oct 1, 2024
9 checks passed
@AskAlexSharov AskAlexSharov deleted the rpc_err branch October 1, 2024 10:33
@cffls
Copy link
Collaborator

cffls commented Oct 3, 2024

If possible, could we please have this fix cherry picked to 2.61 branch for the next erigon release?

@yperbasis yperbasis added this to the 2.60.9-fixes milestone Oct 4, 2024
cffls pushed a commit to 0xPolygonZero/erigon that referenced this pull request Oct 4, 2024
@AskAlexSharov @cffls
Type of error field in structlog logger differs from geth, alloy (er…
1484864 
…igontech#12089)

erigontech#12085
taratorio pushed a commit that referenced this pull request Oct 8, 2024
@AskAlexSharov @taratorio
Type of error field in structlog logger differs from geth, alloy (#1…
7c19a4f 
…2089)

#12085
@taratorio taratorio mentioned this pull request Oct 8, 2024
Merged
@taratorio
Copy link
Member

@cffls here is a PR - #12241

Note the 2.61 branch is not going to be released any time soon. We stick to 2.60 for the time being. All changes on 2.60 will ultimately be sync-ed in 2.61 when the time for that comes.

taratorio added a commit that referenced this pull request Oct 8, 2024
@taratorio @AskAlexSharov
Type of error field in structlog logger differs from geth, alloy (#1…
9516d25 
…2089) (#12241)

cherry-pick #12089 into E2

#12085

Co-authored-by: Alex Sharov <AskAlexSharov@gmail.com>
yperbasis pushed a commit that referenced this pull request Oct 24, 2024
@taratorio @AskAlexSharov @yperbasis
Type of error field in structlog logger differs from geth, alloy (#1…
aeded5e 
…2089) (#12241)

cherry-pick #12089 into E2

#12085

Co-authored-by: Alex Sharov <AskAlexSharov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taratorio taratorio taratorio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.60.9-fixes
Development

Successfully merging this pull request may close these issues.
4 participants
@AskAlexSharov @cffls @taratorio @yperbasis