-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jsonrpc/trace): add creationMethod for parity traces #12557
base: main
Are you sure you want to change the base?
Conversation
Please, to fix RPC Integration tests on this PR try changing the workflow at this line using |
@mriccobene sorry for the inconvenience, for the compatibly reason, we may name it from |
yeah, sounds good to me. May I ask, if this means I can file a PR and set the destination branch as https://github.com/erigontech/rpc-tests/tree/feature/add_createtype_for_parity_traces, or based on the add_createtype_for_parity_traces branch, and send another PR to in https://github.com/erigontech/rpc-tests |
cf5a4f1
to
ae1ca55
Compare
I think it's easier to create a new PR on a fresh branch; my branch can only help you as a guide. Note that in the test run log you can see the failed tests and in the test run artifacts there are the files with the expected and actual values - these files can serve you instead of my branch to fix the failing tests |
ae1ca55
to
59fd33c
Compare
@jsvisa @mriccobene need to merge |
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
59fd33c
to
ae102fd
Compare
similiar to ethereum/go-ethereum#30539 add
creationMethod
for the create traces.