Added grafana dashboards for new metrics #12927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh0lt
approved these changes
Dec 1, 2024
shohamc1
approved these changes
Dec 1, 2024
taratorio
reviewed
Dec 11, 2024
| "refId": "B" | ||
| } | ||
| ], | ||
| "title": "Block finalisation", |
There was a problem hiding this comment.
Please move this to a new Polygon section since these are Polygon specific charts and rename the title to Waypoint lengths
taratorio
reviewed
Dec 11, 2024
| "uid": "${DS_PROMETHEUS}" | ||
| }, | ||
| "editorMode": "code", | ||
| "expr": "wiggle_duration{instance=~\"$instance\",quantile=\"$quantile\"}", |
There was a problem hiding this comment.
Please move this into a separate graph into the Polygon section as per https://github.com/erigontech/erigon/pull/12927/files#r1880458962
taratorio
reviewed
Dec 11, 2024
| "refId": "B" | ||
| } | ||
| ], | ||
| "title": "Block finalisation", |
There was a problem hiding this comment.
do you know why we had to upload the same graphs twice in erigon.json and erigon_internals.json? What are their intended usages? I would've expected that adding it to erigon_internals.json would be enough?
taratorio
added a commit
that referenced
this pull request
Jan 6, 2025
removes outdated charts we added as part of #12927 because: 1. these were changed and superseded by new versions in erigon_internals as part of #13309 2. no need to duplicate these both in `prometheus/dashboards/erigon.json` and `prometheus/dashboards/erigon_internals.json` - only `erigon_internals.json` is enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.