Pre-Shapella blocks must have nil withdrawals #13027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the hack works, it's okay for now. But the hack/fix should be applied at the snapshots reader code. I don't know if older snapshots are forever immutable for Erigon2, but we may need to alter the snapshots too. |
OK, I moved the hack to the snapshots reader. (I had to cherry pick PR #13028.) Perhaps we can regenerate block snapshots after E3 is released. |
somnathb1
approved these changes
Dec 10, 2024
yperbasis
added a commit
that referenced
this pull request
Dec 10, 2024
Apparently we saved some pre-Shappella blocks into snapshots with empty rather than nil withdrawals. This is a work-around for issues like #12297 to avoid regenerating block snapshots. You can see the problem by running ``` curl -X POST -H "Content-Type: application/json" --data '{"jsonrpc":"2.0","method":"eth_getBlockByNumber","params":["0x103716A",false],"id":1}' http://localhost:8545 ```
This was referenced Dec 10, 2024
yperbasis
added a commit
that referenced
this pull request
Dec 10, 2024
Cherry pick PR #13027 into `release/2.61`
yperbasis
added a commit
that referenced
this pull request
Dec 12, 2024
Cherry pick PR #13027 into `main`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we saved some pre-Shappella blocks into snapshots with empty rather than nil withdrawals. This is a work-around for issues like #12297 to avoid regenerating block snapshots. You can see the problem by running