silkworm: add state snapshots #13766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battlmonstr
force-pushed
the
pr/sw_state_snapshots
branch
3 times, most recently
from
05c43e7 to
9e10d1d
Compare
battlmonstr
force-pushed
the
pr/sw_state_snapshots
branch
from
9e10d1d to
8b01de4
Compare
battlmonstr
force-pushed
the
pr/sw_state_snapshots
branch
from
8b01de4 to
e4e12d8
Compare
battlmonstr
requested review from
AskAlexSharov,
awskii,
sudeepdino008,
canepat and
JacekGlen
and removed request for
AskAlexSharov and
awskii
battlmonstr
force-pushed
the
pr/sw_state_snapshots
branch
from
e4e12d8 to
ce762ec
Compare
battlmonstr
force-pushed
the
pr/sw_state_snapshots
branch
from
ce762ec to
0d38d22
Compare
| } | ||
| return DomainSnapshot{ | ||
| Segment: memoryMappedFile(item.Segment()), | ||
| ExistenceIndex: silkworm_go.MemoryMappedFile{ |
There was a problem hiding this comment.
either HashMap index or bt+existence index exist. Maybe we should avoid creating memoryMappedFile always for existence/btree?
Can do this more generally by exposing AccessorList in state.FilesItem, and checking this AccessorList for deciding which indexes to set in DomainSnapshot.
There was a problem hiding this comment.
You're right. I'm planning to do this in a follow up work to make this configurable. For now we've decided to workaround this by disabling passing Commitment files because it is the only domain that does it differently at the moment, and we don't support it fully on the silkworm side yet anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Silkworm library was capable of reading Erigon 2 "blocks" snapshots (.seg and .idx). The code to provide them to Silkworm was a part of RoSnapshots. The old code is moved to be a part of silkworm.SnapshotsRepository, and migrated to the updated Silkworm C API.
The new code adds an ability to provide Erigon 3 "state" snapshots for reading by Silkworm during evmone execution mode (
--silkworm.exec). It is based on the AggregatorRoTx.StaticFilesInRange method that was made public (with the related DTOs) to be accessible from the silkworm package.BtIndex.DataHandle() added to expose the memory mapped file pointer to Silkworm (in the same way as Decompressor and recsplit.Index). A bunch of public methods added to filesItem via FilesItem interface to expose the snapshot file objects to Silkworm.