allow multiple log subscriptions at the same time #5358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created to tackle #4030
The shared log subscription that handles logs and passes them back to the filters for the consumer was losing track of the "all addresses" and "all topics" when another subscription came in causing the aggregates count of AllAddresses or AllTopics to rise above 1. This created a scenario where no subscriptions would receive any logs at all as the first check for AllAddresses would fail so the code checks the Addresses collection which is empty so nothing gets through at all.