Add full support to beacon snapshots #8665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giulio2002
force-pushed
the
fix-beacon-snapshots
branch
from
1185003
to
5a2d67a
Compare
| continue | ||
| } | ||
| addedNew++ | ||
| if strings.HasSuffix(name, ".v.torrent") || strings.HasSuffix(name, ".ef.torrent") { |
There was a problem hiding this comment.
Whitelist is better - then in future can add new types.
There was a problem hiding this comment.
what do you mean? this is your code here, I just added the check that errors out if we have a torrent hash mismatching with our hardcoded ones
There was a problem hiding this comment.
this is all I added to your original code: https://github.com/ledgerwatch/erigon/blob/c976b01a11b6b33037456ad4ffd297ffc13fa073/erigon-lib/downloader/webseed.go#L295
There was a problem hiding this comment.
I mean: erigon 3 has also .kv.torrent files and maybe we will add other extensions in future.
Giulio2002
changed the title
AskAlexSharov
approved these changes
Nov 13, 2023
AskAlexSharov
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds beacon blocks snapshots for the following chains: