Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txpool: limit transactions outgoing messages (#8271) #8742

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

battlmonstr
Copy link
Contributor

@battlmonstr battlmonstr commented Nov 16, 2023

  • limit remote transactions re-broadcast to 3-6 peers
    Broadcasting to 100 peers generates too much outgoing traffic.
  • limit transactions count/size in PooledTransactions replies

Before it was sending 5.5-6.5 MiB/sec:

Screenshot 2023-11-17 at 15 50 15

With the fixes it stays at 3-3.5 MiB/sec:

Screenshot 2023-11-17 at 15 39 10

P.S. A baseline if everything is disabled (BroadcastPooledTxs, AnnouncePooledTxs, responses to GetPooledTransactions) is 0.5-1 MiB/sec.

@battlmonstr battlmonstr changed the title txpool: limit transactions broadcast to 5 peers (#8271) txpool: limit transactions broadcast to 3-5 peers (#8271) Nov 16, 2023
@battlmonstr battlmonstr changed the title txpool: limit transactions broadcast to 3-5 peers (#8271) txpool: limit transactions broadcast to 3-6 peers (#8271) Nov 16, 2023
@battlmonstr battlmonstr changed the title txpool: limit transactions broadcast to 3-6 peers (#8271) txpool: limit transactions outgoing messages (#8271) Nov 17, 2023
@battlmonstr battlmonstr marked this pull request as ready for review November 17, 2023 14:52
@AskAlexSharov AskAlexSharov merged commit 9623b7c into devel Nov 20, 2023
7 checks passed
@AskAlexSharov AskAlexSharov deleted the pr/8271 branch November 20, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants