-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turbo/jsonrpc: add support for bor state sync event tx tracing in debug API #9267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 35a7d06.
mh0lt
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #7504.
With this change Erigon will support correct behaviour for tracing bor state sync event tx-es in the Debug API.
High-level changes:
blockReader.EventLookup
to determine if a transaction hash is a bor state sync txnblockReader.EventsByBlock
to fetch state sync events from the db/snapshots and execute these correctly using the state receiver smart contract with tracingborStateSyncTxnTracer
which wraps around user specified tracers in order to properly handle the fact that each state sync event is executed as if it was a separate sub-call of the bor state sync synthetic transaction but we have no way to execute it like this so need to "trick" the tracerstxnByHash
func - if a transaction does not exist in the snapshots (seg files) but we've encountered another tx in the loop for which the "first byte txnHash check" (check logic) passes then the function will incorrectly return the tx with the matching first byte instead of returning "no transaction found". I run into this by chance while working on this PRTests:
In addition to the below I've tested behaviour with multiple tracers - callTracer, 4byteTracer, prestateTracer, default tracer, bigramTracer, etc. and with traceBlock endpoints in the Debug API however I've omitted listing the responses here as the PR description gets quite big. I've also tested with normal transactions that are not state sync synthetic ones.
Request with bor tracing disabled - "borTraceEnabled: false"
Request with bor tracing enabled - "borTraceEnabled: true"