New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass slice of versionedHashes by value #9281

Merged

yperbasis merged 1 commit into devel from hive_withdrawal

Jan 22, 2024

Member

yperbasis commented Jan 22, 2024 •

edited

Loading

golang slice can be nil. There's no reason to pass it by pointer.

This is a fix to PR #9257. It fixes the following error in Hive test "Withdrawals Fork on Block 1 (Paris)":

<< (0953747c) {"jsonrpc":"2.0","id":5,"error":{"code":-32000,"message":"ethereumExecutionModule.InsertBlocks: blob gas used is nil"}}
CLMocker: Could not ExecutePayloadV1: ethereumExecutionModule.InsertBlocks: blob gas used is nil
CLMocker: BroadcastNewPayload Error (0953747c): ethereumExecutionModule.InsertBlocks: blob gas used is nil


          Pass slice of versionedHashes by value

e420506

yperbasis requested review from somnathb1, Giulio2002 and racytech

January 22, 2024 14:19

AlexeyAkhunov approved these changes

View reviewed changes

yperbasis merged commit fa79cc1 into devel

7 checks passed

yperbasis deleted the hive_withdrawal branch

January 22, 2024 15:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet