Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapmutation.Flush to use less ram and close collectors earlier #9320

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Mapmutation.Flush to use less ram and close collectors earlier #9320

merged 1 commit into from
Jan 26, 2024

Conversation

AskAlexSharov
Copy link
Collaborator

No description provided.

@battlmonstr battlmonstr removed their assignment Jan 26, 2024
battlmonstr
battlmonstr approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@battlmonstr battlmonstr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helped me to go past the batch at block number=2429426, but it hung at the next batch, and it didn't seem to change the max heap usage of membatch Mapmutation.

@battlmonstr battlmonstr merged commit aefb97b into devel Jan 26, 2024
7 checks passed
@battlmonstr battlmonstr deleted the map_mut_collector_use_less_ram branch January 26, 2024 14:43
@BrewTestBot BrewTestBot mentioned this pull request Feb 22, 2024
Closed
somnathb1 added a commit that referenced this pull request Mar 11, 2024
@somnathb1
Revert "Mapmutation.Flush to use less ram and close collectors earlier (
2f23012 
#9320)"

This reverts commit aefb97b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@battlmonstr battlmonstr battlmonstr approved these changes

@AlexeyAkhunov AlexeyAkhunov Awaiting requested review from AlexeyAkhunov

@Giulio2002 Giulio2002 Awaiting requested review from Giulio2002

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AskAlexSharov @battlmonstr