Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use GMP from Conan on Windows too #1184

Merged
merged 4 commits into from
May 29, 2023
Merged

CI: use GMP from Conan on Windows too #1184

merged 4 commits into from
May 29, 2023

Conversation

battlmonstr
Copy link
Contributor

No description provided.

@yperbasis
Copy link
Member

If GMP is available with Conan for windows, we can unset MPIR_INSTEAD_OF_GMP and use GMP on all platforms. Some time ago GMP was not compatible with Windows (or at least that was my impression) and that was why I added MPIR_INSTEAD_OF_GMP to libff. But perhaps now GMP from Conan works fine for Windows.

@battlmonstr
Copy link
Contributor Author

If GMP is available with Conan for windows, we can unset MPIR_INSTEAD_OF_GMP and use GMP on all platforms. Some time ago GMP was not compatible with Windows (or at least that was my impression) and that was why I added MPIR_INSTEAD_OF_GMP to libff. But perhaps now GMP from Conan works fine for Windows.

@yperbasis 👌 will try

@battlmonstr battlmonstr force-pushed the ci/conan_mpir branch 3 times, most recently from f549125 to 210a478 Compare May 26, 2023 12:25
@battlmonstr
Copy link
Contributor Author

core_test build gets the following errors now:

error LNK2038: mismatch detected for '_ITERATOR_DEBUG_LEVEL': value '0' doesn't match value '2' in unit_test.obj
error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MD_DynamicRelease' doesn't match value 'MDd_DynamicDebug' in unit_test.obj

in
absl_hash.lib(hash.obj)
absl_city.lib(city.obj)
absl_low_level_hash.lib(low_level_hash.obj)
absl_raw_hash_set.lib(raw_hash_set.obj)

and finally:

C:\build\cmd\test\Debug\core_test.exe : fatal error LNK1319: 8 mismatches detected [C:\build\cmd\test\core_test.vcxproj]

It looks like absl and unit_test.cpp from core_test suddenly use different version of the CRT, but why? 🤔

It doesn't seem related to GMP though, could be that the Debug build on Windows CI is broken.

@battlmonstr battlmonstr changed the title CI: use mpir from Conan on Windows CI: use GMP from Conan on Windows too May 26, 2023
@battlmonstr battlmonstr requested review from canepat and yperbasis May 26, 2023 14:50
@battlmonstr battlmonstr marked this pull request as ready for review May 26, 2023 14:50
@canepat
Copy link
Member

canepat commented May 28, 2023

@mriccobene can you please give this PR a try on your Windows machine? Unfortunately, our Windows CI job does not build the silkworm target because it still suffers an issue (the dreaded compiler out of heap space in step 2).

@battlmonstr
Copy link
Contributor Author

battlmonstr commented May 29, 2023

@canepat I'd like to merge it now, because it also fixes #1171 . GMP is used in precompile.cpp from core, and building core is verified by the CI. It is still nice to test the full build on Windows, and if there are any further issues with the silkworm target, I can address it in a new PR.

@battlmonstr battlmonstr merged commit e5c3f67 into master May 29, 2023
@battlmonstr battlmonstr deleted the ci/conan_mpir branch May 29, 2023 10:15
@canepat canepat mentioned this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants