build: no need for -fpic #1193
Merged
build: no need for -fpic #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
approved these changes
May 29, 2023
There was a problem hiding this comment.
There is a bit more to this. You can also produce Position Independent Executable (PIE) although I'm not sure if CMake supports it directly. The PIE enhances address space layout randomization (ASLR).
To the point: some compilers (e.g. GCC on Debian) are configured to use PIC/PIE by default. Then you need to disable it manually (e.g. -no-pie, -fno-PIC).
But the change itself is good.
yperbasis
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Position independent code is required for shared libraries, which we don't use. Moreover, cmake sets pic to true automatically for shared libs.